From 29d365293c04b2a68aa530aeb37fea5256abd93f Mon Sep 17 00:00:00 2001 From: Sandwich Date: Thu, 12 Feb 2026 23:33:55 +0100 Subject: [PATCH] fix(banner): correct visudo validate, clean trailing whitespace --- roles/configuration/tasks/banner.yml | 2 +- roles/configuration/tasks/locales.yml | 1 - roles/global_defaults/tasks/system.yml | 4 +--- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/roles/configuration/tasks/banner.yml b/roles/configuration/tasks/banner.yml index 41cfe2b..aee3bc7 100644 --- a/roles/configuration/tasks/banner.yml +++ b/roles/configuration/tasks/banner.yml @@ -52,4 +52,4 @@ mode: "0440" owner: root group: root - validate: "visudo -cf - %s" + validate: "/usr/sbin/visudo --check --file=%s" diff --git a/roles/configuration/tasks/locales.yml b/roles/configuration/tasks/locales.yml index 912ebdc..8b62dd7 100644 --- a/roles/configuration/tasks/locales.yml +++ b/roles/configuration/tasks/locales.yml @@ -28,7 +28,6 @@ register: configuration_locale_result changed_when: configuration_locale_result.rc == 0 - - name: Compute hostname variables ansible.builtin.set_fact: configuration_dns_domain: >- diff --git a/roles/global_defaults/tasks/system.yml b/roles/global_defaults/tasks/system.yml index 650f5b2..84145fa 100644 --- a/roles/global_defaults/tasks/system.yml +++ b/roles/global_defaults/tasks/system.yml @@ -229,7 +229,6 @@ - name: Initialize normalized disk list ansible.builtin.set_fact: system_disks_cfg: [] - - name: Build normalized system disk configuration vars: @@ -289,7 +288,6 @@ - name: Update system configuration with normalized disks ansible.builtin.set_fact: system_cfg: "{{ system_cfg | combine({'disks': system_disks_cfg}, recursive=True) }}" - - name: Set install_drive from primary disk when: @@ -297,4 +295,4 @@ - system_disks_cfg[0].device | string | length > 0 ansible.builtin.set_fact: install_drive: "{{ system_disks_cfg[0].device }}" - +