fix(cleanup): fix vmware CD-ROM omit fragility and add cross-role defaults

roles/cleanup/tasks/libvirt.yml

@@ -99,6 +99,7 @@
         name: "{{ hostname }}"
         state: running
 
+    # delegate_to inventory_hostname: overrides play-level localhost to run wait_for_connection against the VM
     - name: Wait for VM to boot up
       delegate_to: "{{ inventory_hostname }}"
       ansible.builtin.wait_for_connection:

roles/cleanup/tasks/vmware.yml

@@ -12,19 +12,33 @@
         validate_certs: "{{ hypervisor_cfg.certs | bool }}"
         datacenter: "{{ hypervisor_cfg.datacenter }}"
         name: "{{ hostname }}"
-        cdrom:
+        cdrom: >-
-          - controller_number: 0
+          {{
-            unit_number: 0
+            [
-            controller_type: sata
+              {
-            type: iso
+                'controller_number': 0,
-            iso_path: "{{ boot_iso }}"
+                'unit_number': 0,
-            state: absent
+                'controller_type': 'sata',
-          - controller_number: 0
+                'type': 'iso',
-            unit_number: 1
+                'iso_path': boot_iso,
-            controller_type: sata
+                'state': 'absent'
-            type: iso
+              }
-            iso_path: "{{ rhel_iso if rhel_iso is defined and rhel_iso | length > 0 else omit }}"
+            ]
-            state: absent
+            + (
+              [
+                {
+                  'controller_number': 0,
+                  'unit_number': 1,
+                  'controller_type': 'sata',
+                  'type': 'iso',
+                  'iso_path': rhel_iso,
+                  'state': 'absent'
+                }
+              ]
+              if rhel_iso is defined and rhel_iso | length > 0
+              else []
+            )
+          }}
       failed_when: false
       no_log: true
 

roles/cleanup/tasks/xen.yml

@@ -3,6 +3,8 @@
   when: hypervisor_type == "xen"
   delegate_to: localhost
   become: false
+  vars:
+    xen_installer_media_enabled: "{{ xen_installer_media_enabled | default(false) }}"
   block:
     - name: Ensure Xen disk definitions exist
       when: virtualization_xen_disks is not defined